Skip to content

npcs: SCNpcInteractionSkillList lists the skills of the NPC's interaction set - #40

Merged
NickMesser merged 1 commit into
rust-rewritefrom
fix/npc-interaction-sets
Oct 23, 2026
Merged

NickMesser merged 1 commit into
rust-rewritefrom
fix/npc-interaction-sets

Conversation

@NickMesser

Copy link
Copy Markdown
Owner

What

CSStartInteraction answered [0] for an NPC without a function flag (merchant, banker, ...), so the client never learned what npc_interactions gives the NPC. The 1.2 client dispatches the first skill of SCNpcInteractionSkillList; the beauty salon helper (npcs 13640, npc_interaction_set_id 12) is meant to offer skill 22780 "Enter the beauty salon", which opens the original confirm dialog and then CSEnterBeautySalon.

Change

  • NpcData loads npc_interactions (npc_interaction_set_id -> skill_id in table order).
  • interaction_skills(data, template): the function of the NPC (interaction_option) still wins as before; otherwise the skills of its interaction set; otherwise [0] as before.
  • CSStartInteractionPacket sends that list.

Tests

cargo test -p aaemu-game --lib systems::npcs::npc (63 passed): the set is loaded in table order, a functionless NPC gets its set's skills, an unknown set stays [0], a merchant keeps [12087].

Needs a lane restart with fix/npc-interaction-sets to take effect on the live server (the NPC 13640 has no spawn in main_world's npc_spawns.json, so a GM spawn is needed to try it).

🤖 Generated with Claude Code

…tion set

CSStartInteraction answered 0 for an NPC without a function flag, so the
client never offered what npc_interactions gives it (the beauty salon
helper's 'Enter the beauty salon', skill 22780). npc_interactions is loaded
per npc_interaction_set_id; when no function applies the answer lists the
set's skills in table order, and the function still wins when there is one.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 39972416593

Warning

No base build found for commit 180b4fd on rust-rewrite.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 76.705%

Details

  • Patch coverage: 36 of 36 lines across 2 files are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 259021
Covered Lines: 198681
Line Coverage: 76.7%
Coverage Strength: 29379.59 hits per line

💛 - Coveralls

@NickMesser
NickMesser merged commit ca7039c into rust-rewrite Oct 23, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants