Repository navigation
npcs: SCNpcInteractionSkillList lists the skills of the NPC's interaction set - #40
Merged
Merged
Conversation
…tion set CSStartInteraction answered 0 for an NPC without a function flag, so the client never offered what npc_interactions gives it (the beauty salon helper's 'Enter the beauty salon', skill 22780). npc_interactions is loaded per npc_interaction_set_id; when no function applies the answer lists the set's skills in table order, and the function still wins when there is one. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Coverage Report for CI Build 39972416593Warning No base build found for commit Coverage: 76.705%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CSStartInteractionanswered[0]for an NPC without a function flag (merchant, banker, ...), so the client never learned whatnpc_interactionsgives the NPC. The 1.2 client dispatches the first skill ofSCNpcInteractionSkillList; the beauty salon helper (npcs13640,npc_interaction_set_id12) is meant to offer skill 22780 "Enter the beauty salon", which opens the original confirm dialog and thenCSEnterBeautySalon.Change
NpcDataloadsnpc_interactions(npc_interaction_set_id->skill_idin table order).interaction_skills(data, template): the function of the NPC (interaction_option) still wins as before; otherwise the skills of its interaction set; otherwise[0]as before.CSStartInteractionPacketsends that list.Tests
cargo test -p aaemu-game --lib systems::npcs::npc(63 passed): the set is loaded in table order, a functionless NPC gets its set's skills, an unknown set stays[0], a merchant keeps[12087].Needs a lane restart with
fix/npc-interaction-setsto take effect on the live server (the NPC 13640 has no spawn inmain_world'snpc_spawns.json, so a GM spawn is needed to try it).🤖 Generated with Claude Code